Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix required opt-in for sendResult test helper #937

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix required opt-in for sendResult test helper #937

merged 2 commits into from
Nov 11, 2024

Conversation

gabrielittner
Copy link
Member

Using ContractResultOwner requires opt in while ActivityResultRequest does not. Since the only other subclass of ContractResultOwner is PermissionsResultRequest which has separate helpers below this, I've simply changed the class on which the extension is defined.

@gabrielittner gabrielittner merged commit c9eaa99 into main Nov 11, 2024
4 checks passed
@gabrielittner gabrielittner deleted the optin branch November 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kboyarshinov kboyarshinov kboyarshinov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielittner @kboyarshinov